I have found the issue, select your Battlefield 4 game and click start (3 line button) and then select manage game, then select your premium add on next to the main game with the start button again, then choose visit details, which will take you to the Xbox One store. When there scroll down and take a look at the add-ons list, and one by one click on them and select the option to install them, previously on 360, these would all be automatically added to our download list but we have to manually choose and install them now.
This is how I resolved my issue, I had bought premium but was being told to download DLC everytime I wanted to join a server that contained DLC.
I have installed, uninstalled, and reinstalled all the map packs according to the previous suggestions, but am still getting the same issue:
1. Try to join an e.g. DLC or night operations server
2. Get message saying you need premium et al
3. press on premium in the list of expansion packs
4. Get prompt saying I already own premium et al
How to fix?